pelias / pelias/api

Consider coordinates in deduping

Open
#532 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

processed
Dominant language
JavaScript
Stars
259
Forks
168
Avg merge
6h 15m
Merged PRs (30d)
1

Description

Most data sources do not require that names or addresses are unique. For example, a large shopping mall or leisure park might have several customer service sites, all called as 'Customer service' but with different coordinates. Currently deduping removes all but the first entry. Maybe this is not the right action?

Anyway, allowing duplicate names would set some new requirements for label generation, because the user must be able to differentiate the presented items. One possibility would be adding some automatic qualifiers such as 'Customer service (north)' etc.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files, tests, or entry points are named. Start by locating the API's deduplication and label-generation logic, then determine the intended behavior for duplicate names with different coordinates and how users should distinguish the results; done requires an agreed design and corresponding coverage.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
api, search
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.