Geoname features not returned when queried together with osm source.
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 259
- Forks
- 168
- Avg merge
- 6h 15m
- Merged PRs (30d)
- 1
Description
Describe the bug
When querying via /v1/search API, geoname features are missing from the results when the source=gn,osm that are returned as expected when the source=gn.
Steps to Reproduce
Using a Pelias server built using the docker/project/australia setup:
Query explicitly from gn:
curl -s "http://localhost:4000/v1/search?text=diamantina+river&sources=gn"
returns 10 results from gn.
Query with both sources:
curl -s "http://localhost:4000/v1/search?text=diamantina+river&sources=gn,osm"
returns 1 result from osm.
Expected behavior
The query with both source osm, and gn was expected to return all 11 results (1 from osm, 10 from gn).
Environment (please complete the following information):
- OS: Windows
- Docker version 20.10.24
- Docker Compose version v2.17.2
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the /v1/search API handling for combined sources, using the two curl requests in the issue to reproduce the difference between sources=gn and sources=gn,osm. Compare the returned source results and add or update coverage so the combined query returns both the osm result and the 10 gn results.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- api, search
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100