Wrong field in admin_multi_match_first query
@Joxit is already working on this.
Since Oct 16, 2020.
- Dominant language
- JavaScript
- Stars
- 259
- Forks
- 169
- Avg merge
- 6h 15m
- Merged PRs (30d)
- 1
Description
Describe the bug
Heeeeey @Joxit
I was investigating a bug report today and I noticed something on our dev server which looks incorrect:
https://pelias.github.io/compare/#/v1/autocomplete?lang=de&text=Am+Gro%C3%9Fhausberg%2C+Furtwangen+im+Schwarzwald+deut&debug=1Dev server is running a newer
masterbranch than the production server.![]()
The screenshot shows it's using
phrase.defaultbutname.de, is that possibly due to this PR?
I would expect to seephrase.defaultandphrase.de.
Originally posted by @missinglink in https://github.com/pelias/api/pull/1493#issuecomment-709947256
Expected behavior
We should use the phrase.{lang} field instead of name.{lang}.
Additional context
Here is where we update the name.default field to phrase.default:
The lang from clean is not available in this function... We may add a new property lang in the view ?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.