pelias / pelias/api

Regressions between addressit parser and pelias parser

Open
#1,448 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
JavaScript
Stars
259
Forks
168
Avg merge
6h 15m
Merged PRs (30d)
1

Description

Hi,

The pelias parser seems to do an good job, although, I've noticed a few of regressions between the addressit and the pelias parser versions of the API.

Here's a few I've found:

Query: D-Block mini Park, Dhaka District, Dhaka, Bangladesh
addressit version: D-Block mini Park, Dhaka, Bangladesh
pelias parser version: Mini Park, NS, Canada

Query: kim jong yu paradise, Pyongyang City, P´yongyang-si, North Korea
addressit version: kim jong yu paradise, Pyongyang, North Korea
pelias parser version: Yongyang Road, China

Query: Afognak Native Corp, Anchorage, Municipality of Anchorage, Alaska, United States
addressit version: Afognak Native Corp, Anchorage, AK, USA
pelias parser version: municipality of curepipe, Mauritius

Query: City Auto, Dili, East Timor
addressit version: City Auto, Dili, East Timor
pelias parser version: Auto City Speedway, Vienna, MI, USA

When debugging more, I've found that parts of the input string which are not classified by the pelias parser are skipped in the DB queries sent to Elasticsearch, which gives results that do not even belong to the same country.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the four example queries and comparing addressit with the Pelias parser, then inspect how unclassified input is turned into Elasticsearch queries. Done should mean the reported queries return results in the intended country and that unclassified input does not cause unrelated-country matches.

Written by the indexing model from the issue text.

Assessment

Tech stack
elasticsearch, javascript
Domain
api, backend, search
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.