pelias / pelias/api

Trailing comma in admin matching subquery

Open
#1,394 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

help wanted low priority
Dominant language
JavaScript
Stars
259
Forks
169
Avg merge
6h 15m
Merged PRs (30d)
1

Description

The following query is generating an admin matching clause where the token contains a trailing comma.
Although this will not affect matching, the comma should not be present.

/v1/autocomplete?debug=true&text=Koh Lanta, Gothenburg, Sweden

...
"query": "Gothenburg,",
...

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with the provided /v1/autocomplete?debug=true request and inspect the admin matching subquery that produces the debug query token. The work is done when the generated "query" value is "Gothenburg" rather than "Gothenburg," and matching behavior remains unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
api, search
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.