search_with_ids controller being used when placeholder has not been called
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 259
- Forks
- 169
- Avg merge
- 6h 15m
- Merged PRs (30d)
- 1
Description
@orangejulius I noticed this today when querying:
/v1/search?debug=true&text=10 main st 10010
The first query in the debug output is controller:search_with_ids, I thought that was only relevant when ids had been returned from placeholder?
In this case, the placeholder service hasn't been called.
The query actually returns decent results, so maybe it's just a logging error?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the /v1/search request and its debug output, then trace where controller:search_with_ids is selected relative to the placeholder call. Determine whether the controller label is wrong or the controller is actually being used; done means the debug output accurately reflects the request path.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- api, search
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100