Problems with pelias/api commit "feat(confidence): Add support for new query names"?
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 259
- Forks
- 169
- Avg merge
- 6h 15m
- Merged PRs (30d)
- 1
Description
Hi @orangejulius ,
I believe that there is a problem with your commit for "feat(confidence): Add support for new query names". In middleware/confidenceScoreFallback.js: line 28, I see 2 potential problems:-
- Shouldn't res.meta.queryType be res.meta.query_type?
- Shouldn't 'search_original' be present in the include list along with ''search_fallback', 'address_search_with_ids' and 'structured'?
I would be happy to get your feedback regarding this.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with middleware/confidenceScoreFallback.js at line 28 and compare it with commit 2a668612edc1ce383835f84b6bbf9da60bb40c7b. Check the query metadata key and the include list against the names used by the API. Done means confirming the expected names and documenting or correcting both discrepancies, with the relevant behavior verified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- api
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100