peerigon / peerigon/parse-domain

So slow!

Open
#243 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
517
Forks
70
Avg merge
3h 38m
Merged PRs (30d)
3

Description

Using v8.x, my test suite of 23,104 URLs takes 110 seconds to run! v4.x only takes 7 seconds, so I'll have to stick with that version for now.

Should you have used net.isIP instead of is-ip?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the reported benchmark for 23,104 URLs on v8.x and compare it with v4.x. Investigate the net.isIP and is-ip entry points mentioned in the issue; done means identifying and addressing the regression so the suite returns to an acceptable runtime.

Written by the indexing model from the issue text.

Assessment

Tech stack
node.js, typescript
Domain
performance
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.