peerigon / peerigon/clockodo

Consider loosening tests to not fail on presence of additional keys in API response

Open
#79 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
23
Forks
7
Avg merge
6h 22m
Merged PRs (30d)
8

Description

Right now if Clockodo adds a new property to their response, some of our tests that are expecting properties to match one-to-one would fail. We should consider removing this check altogether, or allow for additional properties to be present.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the tests that compare Clockodo API response properties one-to-one and read their current expectations. Run the relevant test suite, then make the tests tolerate additional response keys while continuing to verify the expected properties.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api, testing
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.