Official and localized models
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 379
- Forks
- 75
- PR merge metrics
- No merged PRs in 30d
Description
When an image file contains an alias of the camera model, rather than the official camera model, there is no way to relate back to the official model.
For example, with a T3i, I would expect to get back the official model of Canon EOS 600D (from data/cameras/canon/600d.toml) when calling camera.model. However, instead I get back the localized model Canon EOS REBEL T3i.
This can introduce difficulties when you want to branch behaviour based on the camera model as each localized case must be handled, rather than a single official model case.
Proposal would be to modify RawImage.{model, clean_model} to return the official model name, and add two new properties RawImage.{localized_model, clean_localized_model} that return the localized model name.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading data/cameras/canon/600d.toml and the RawImage.model and RawImage.clean_model implementation. Trace how the localized Canon EOS REBEL T3i value is selected, then determine how official and localized names should be exposed separately. Done means camera.model returns Canon EOS 600D while the new localized properties return Canon EOS REBEL T3i.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- computer-vision
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100