pebble-dev / pebble-dev/rebble-appstore-api

Some apps have an invalid `has_binary` field

Open
#88 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
20
Forks
9
PR merge metrics
No merged PRs in 30d

Description

Example: https://appstore-api.rebble.io/api/v1/apps/id/69a30474521b3b000990cadd (which is also present in home feed for apps: https://appstore-api.rebble.io/api/v1/apps/id/69a30474521b3b000990cadd) has:

"basalt": {
          "firmware": {
            "major": 3
          },
          "has_binary": {

          },
          "supported": true
        },

where is_binary should be a boolean, so the app is having trouble parsing that field as an empty object (null would be fine if we don't have the data to populate it).

Every other app in the home feed looks good e.g.:

"basalt": {
          "firmware": {
            "major": 3
          },
          "has_binary": true,
          "supported": true
        },

ref: https://discord.com/channels/221364737269694464/1412426648384438403/1477724223387729971

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the app detail and home-feed API endpoints for app ID 69a30474521b3b000990cadd and locate where the platform has_binary value is assembled. Compare that response with apps returning a boolean, then verify that missing binary data is emitted as a boolean or null rather than an empty object.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.