pcdshub / pcdshub/pcdsutils

LazyWidget margins should be investigated and minimized

Open
#56 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
2
Forks
6
Avg merge
7d 11h
Merged PRs (30d)
1

Description

The default margins on all layouts is nonzero, LazyWidgets will be slightly smaller than intended.

Ideally, there would be zero margin and using a LazyWidget would be functionally equivalent to the normal widget once instantiated.

Paraphrased comment by @ZLLentz in https://github.com/pcdshub/pcdsutils/pull/55#discussion_r888287854

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating LazyWidget and the default margin definitions for layouts, then compare a lazy widget with the corresponding normal widget after instantiation. Use the discussion linked in the issue for context; done means minimizing the default margin, ideally to zero, so both widgets are functionally equivalent.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.