pcdshub / pcdshub/pcdsdaq

Revisit daq controls configuration use of `.value` attribute

Open
#89 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
0
Forks
9
Avg merge
7d 6h
Merged PRs (30d)
1

Description

Expected Behavior

Should not use a deprecated attribute

Current Behavior

Uses deprecated .value attribute for signals

Possible Solution

Only allow .position, .get(), .get()[0]

Context

Suggested in https://github.com/pcdshub/nabs/pull/24#discussion_r514490921

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the DAQ controls configuration code and searching for signal uses of the deprecated .value attribute. Review the nabs pull-request discussion linked in the issue. Done means the configuration allows only .position, .get(), or .get()[0] as described.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.