pcdshub / pcdshub/pcdsdaq

Add ability to configure events, duration during a run

Open
#53 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
0
Forks
9
Avg merge
7d 6h
Merged PRs (30d)
1

Description

Expected Behavior

Daq.configure needs to be callable in the middle of a bluesky plan if we want to change the length of a trigger_and_read call, e.g. run for x events and then change something and run for y events.

Current Behavior

Cannot call configure at all if a run is open.

Possible Solution

Only the first configure and changes to record state should actually trigger a pydaq.Control.configure call. Every other configurable should be saved and passed through to pydaq.Control.begin.

Context

There are use cases for taking n dark shots and m light shots, where n!=m, and this pattern looks something like:

yield from configure(daq, record=True)
yield from open_run()
yield from configure(daq, events=n)
yield from trigger_and_read(daq)
yield from configure(daq, events=m)
yield from trigger_and_read(daq)
yield from close_run()

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing Daq.configure and the open-run path used with configure, open_run, trigger_and_read, and close_run. Read how pydaq.Control.configure and pydaq.Control.begin are currently called. Done means the shown plan can use different event counts within one open run while preserving the requested record behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.