pcdshub / pcdshub/pcdsdaq

Planned stability changes

Open
#47 1 comment 0 reactions 1 assignee View on GitHub

@ZLLentz is already working on this.

Since Oct 31, 2018.

Dominant language
Python
Stars
0
Forks
9
Avg merge
7d 6h
Merged PRs (30d)
1

Description

Some of the underlying pydaq interface works differently than one would expect. For thread safety reasons, it is best to never call pydaq.Control.end under any situations, so I want to do the following changes:

  • Replace calling end with polling state at ~5Hz
  • Wrap all pydaq calls behind a threading.Lock
  • Only one thread at a time watching for state transitions
  • Forward partition, dbalias, etc up to the highest level methods

@ddamiani

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.