pcdshub / pcdshub/pcdsdaq

Support the "Whatever GUI has checked" record option

Open
#18 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Python
Stars
0
Forks
9
Avg merge
7d 6h
Merged PRs (30d)
1

Description

Expected Behavior

Exists an option to defer to DAQ gui's record state

Current Behavior

record=True must be specified, otherwise we'll override the gui and set it to False

Context

pydaq.Control.configure(record=None) defers to the GUI record state, but I'm using record=None as a default "I don't want to touch the config" argument in daq.Daq.configure

Possible Solution

Add an extra string option for record='gui'?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading pydaq.Control.configure(record=None) and the record handling in daq.Daq.configure. Trace how the current default overrides the GUI state, then define and implement the explicit option for deferring to the GUI. Done means callers can preserve the GUI record state without changing the existing behavior of record=None.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.