pcdshub / pcdshub/hutch-python

ELOG station logic weird and wrong for RIX

Open
#369 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1
Forks
18
Avg merge
7d 9h
Merged PRs (30d)
1

Description

Expected Behavior

Each hutch should be able to configure their daq station/elog appropriately.
E.g. if they are running on daq 2, they should post to elog 2, etc.

Current Behavior

Only elogs 0 and 1 are allowed
RIX uses 2

$ cat conf.yml
hutch: rix

# Locate happi database
db: /reg/g/pcds/pyps/apps/hutch-python/device_config/db.json

# Hutch-specific imports
load: rix.beamline

# DAQ interface configuration
daq_type: lcls2

daq_host: drp-srcf-cmp004

daq_platform:
  default: 2

Station is based on whether or not the default is active
I think we put this in for CXI like a million years ago

Possible Solution

Use the config-file provided daq platform to select the elog station when available
Otherwise, fall back to old behavior

Context

RIX elog wasn't loading correctly in hutch python (ever?)

Your Environment

pcds-5.7.1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the ELOG station selection and how the config file's daq_platform.default value is read, using the RIX configuration shown in the issue. Confirm that an available platform selects the matching ELOG station while configurations without it retain the existing behavior, then verify RIX ELOG loading.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.