pcdshub / pcdshub/hutch-python
Remove threshold-based noisy logger checks
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1
- Forks
- 18
- Avg merge
- 7d 9h
- Merged PRs (30d)
- 1
Description
Context
Hushing noisy loggers by threshold of message count was a well-intentioned tool that will just never work as we'd hope:
https://github.com/pcdshub/hutch-python/blob/2234f40dce7f3c4817b55aed0af22060838dd4a6/hutch_python/log_setup.py#L250-L252
It'd be nice if we had figured that out before rolling it out, but better late than never...
Discussion
I think object filters and such can remain, but we should discuss what core parts are useful to keep
Related #338
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading log_setup.py around lines 250-252 and the discussion in related issue #338. Determine which threshold-based noisy-logger checks are no longer useful and which object filters should remain. Done requires an agreed scope for removing or retaining the core logging behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- observability-sre
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100