pcdshub / pcdshub/hutch-python
Only start log message counting background threads if applicable
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1
- Forks
- 18
- Avg merge
- 7d 9h
- Merged PRs (30d)
- 1
Description
Why have a bunch of background threads counting log messages if there is no threshold above which they would be silenced?
This can be changed:
Or we can look to reverting the spammy log message thing entirely. While well-intentioned, I think it was a mistake in retrospect...
Context: Noted in segfault in Travis CI: https://app.travis-ci.com/github/pcdshub/hutch-python/jobs/562743057
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in log_setup.py at lines 352-354 and review the background-thread log counting setup. Check the Travis CI segfault context linked in the issue, then determine whether counting should be skipped without a silencing threshold or whether the spammy logging should be reverted. Done means the unnecessary background threads no longer start, or the logging behavior is intentionally removed, with the CI failure considered.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100