pcdshub / pcdshub/hutch-python

Fix conda-specific assumptions

Open
#290 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1
Forks
18
Avg merge
7d 9h
Merged PRs (30d)
1

Description

Expected Behavior

The tests should pass regardless of if we install the library via conda, pip, or manually via setup.py or otherwise

Current Behavior

There are some explicit checks for conda-related environment variables here:
https://github.com/pcdshub/hutch-python/blob/297a577d1cf7d7926ec27265e4265167c9cabf07/hutch_python/cli.py#L136
and potentially similar shenanigans elsewhere.

Context

PIP build fails

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting the conda-specific environment checks in hutch_python/cli.py around line 136, then search for similar checks elsewhere in the repository. Verify the test and installation behavior with conda, pip, and setup.py or manual installation; done means the tests pass without conda-specific assumptions.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.