pcdshub / pcdshub/hutch-python

Uses deprected value to pick primary or secondary logbook

Open
#136 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1
Forks
18
Avg merge
7d 9h
Merged PRs (30d)
1

Description

We're checking daq_platform to modify the elog object behavior, even though we aren't using this to construct the daq object any more.

To make this cleaner, we should create a primary key that maps to the end station that will be running the primary daq... or maybe we create a more complex mapping directly in the conf file.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing where daq_platform is read and how it changes the elog object during DAQ configuration. Compare that behavior with the current daq object construction and the available .conf mapping. Done means the primary or secondary logbook is selected from the current configuration without relying on the deprecated value, with the chosen mapping documented or covered by existing checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.