pcdshub / pcdshub/engineering_tools
takepeds should stop if pedestal failed
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 5
- Forks
- 36
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 3
Description
If pedestal failed for whatever reason, the script should stop. Currently, it looks like it still proceeds to post in the elog and tell users to call makepeds.
Should stop after this line: https://github.com/pcdshub/engineering_tools/blob/a608fb6e48770726b80462cd0fbeb9f776022319/scripts/takepeds#L6
set -e might work (hoping that take_pedestals gives non-zero status on error)?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect scripts/takepeds at the referenced line and the take_pedestals invocation. Verify how failure status is propagated, then ensure the script stops before posting to the elog or telling users to call makepeds; confirm the failure path behaves as intended.
Written by the indexing model from the issue text.
Assessment
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100