pcdshub / pcdshub/engineering_tools

ENH: Future improvements for BLmotors

Open
#92 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
5
Forks
36
Avg merge
2d 17h
Merged PRs (30d)
3

Description

  1. Remove unnecessary argument handling Originally posted by @ZLLentz in https://github.com/pcdshub/engineering_tools/pull/91#discussion_r768161455
  2. Remove exec call Originally posted by @ZLLentz in https://github.com/pcdshub/engineering_tools/pull/91#discussion_r768167051
  3. Remove unnecessary tuple creation for res Originally posted by @ZLLentz in https://github.com/pcdshub/engineering_tools/pull/91#discussion_r768168231
  4. Clean up file handling Originally posted by @ZLLentz in https://github.com/pcdshub/engineering_tools/pull/91#discussion_r768169181
  5. Simplify device sorting logic Originally posted by @ZLLentz in https://github.com/pcdshub/engineering_tools/pull/91#discussion_r768205059
  6. Fix other things left over from Mike's code...
  7. Parallelize EPICS calls Originally posted by @ZLLentz in https://github.com/pcdshub/engineering_tools/pull/91#discussion_r770753968
  8. Maybe rename?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the BLmotors implementation and reviewing the referenced pull request #91 discussions. Work through the listed argument, exec, tuple, file-handling, sorting, and EPICS-call concerns, and consider the proposed rename; done means the agreed improvements are addressed and the behavior remains correct.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.