pcdshub / pcdshub/engineering_tools
camViewer iocInfo function doesn't always set ioc correctly
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 5
- Forks
- 36
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 3
Description
This function (and iocfpv) is only used for enabling and disabling iocs
https://github.com/pcdshub/engineering_tools/blob/31a267b9c9d46b00e188cc465b68438703b35e44/scripts/camViewer#L120-L132
The loop variable is used as the ioc name for imgr, which will always be the last value in the loop. It should probably be set at the same time as iochutch for consistency and return early.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in scripts/camViewer at lines 120-132 and inspect the iocInfo and iocfpv functions, focusing on how iochutch and imgr receive their IOC names. Confirm the current loop behavior, then make the IOC assignment consistent and return early as described. Done means imgr no longer uses the final loop value when enabling or disabling an IOC.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 52/100