pcdshub / pcdshub/engineering_tools
Make function for experiment request in get_info.py
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 5
- Forks
- 36
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 3
Description
These lines are copied several times in the scripts to get the experiment. Instead, it should be put into a function and called where needed
https://github.com/pcdshub/engineering_tools/blob/c05992ee153b5e4e040005d1b7f2c003aeb471e8/scripts/get_info.py#L174-L176
Originally posted by @KaushikMalapati in https://github.com/pcdshub/engineering_tools/pull/281#discussion_r2074828663
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at scripts/get_info.py lines 174-176 and search the scripts for the repeated experiment-request lines. Identify the shared behavior and its call sites, then confirm that the repeated code is replaced by one reusable function and that the existing experiment lookups still work.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100