pcdshub / pcdshub/engineering_tools
Revise checks for opr users
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 5
- Forks
- 36
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 3
Description
Expected Behavior
Checks for operator users should only find operator users.
Current Behavior
Most checks are implemented via checking if the username contains "opr", which will give false positives for some (rare) users.
Possible Solution
Check specifically for the hutch operator accounts in /cds/home/opr instead:
$ ls /cds/home/opr
cxiopr detopr feeopr hplopr lasopr mccopr mecopr mfxopr rixopr tmoopr tstopr txiopr uedopr xcsopr xppopr
Context
https://github.com/pcdshub/engineering_tools/pull/204#discussion_r1783186408
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the checks discussed in PR #204 and compare their username matching with the operator accounts listed under /cds/home/opr. Done means checks identify only those operator accounts and no longer flag unrelated usernames; verify the affected checks with the project's available tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100