pcdshub / pcdshub/engineering_tools
Dev Screen Reference in motor-expert-screen
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 5
- Forks
- 36
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 3
Description
The motor expert screen makes some odd references to old aerotech screens in Karl's directory (and apparently formerly Mike's directory) here: https://github.com/pcdshub/engineering_tools/blob/master/scripts/motor-expert-screen#L107-L109
It's not clear to me why we're using the old dev paths, and further more why aerotech is the fallback option here.
Possible Solution
The screen location should be updated to a released directory, and at the very least a comment added about the aerotech fallback.
Context
I was perturbed by this when reviewing an un-related PR.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading scripts/motor-expert-screen at lines 107-109 and trace the referenced Karl and former Mike directories. Identify the released directory that should replace the old development path, then document why aerotech remains the fallback. Done means the screen uses the released location and the fallback is explained in a comment.
Written by the indexing model from the issue text.
Assessment
- Domain
- cli, tooling
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100