patternfly / patternfly/react-topology
mobx-react warning on newer versions
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 21
- Forks
- 27
- PR merge metrics
- No merged PRs in 30d
Description
Describe the problem
An import of batchingForReactDom generates a warning with newer version of mobx-react
How do you reproduce the problem?
Create a new TS/JS project that depends on the last version of patternfly/react-topology, and import VisualizationSurface component. Launch the project (in dev)
A warning appears in the browser's console : [mobx-react-lite] importing batchingForReactDom is no longer needed
Expected behavior
No warning
Is this issue blocking you?
Not really, it is just a bit dirty to keep this warning
What is your environment?
-
OS: Windows 10
-
Browser: Firefox
-
Version: 114.0.1
Any other information?
My suggestion would be to bump mobx-react to ^7.0.0, as the import of batchingForReactDom in VisualizationSurface.tsx won't be needed, so we would be able to remove it, which will remove the warning for any accepted version of this library
Jira Issue: PF-1997
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting VisualizationSurface.tsx and the mobx-react dependency/version configuration. Reproduce the warning in a TypeScript or JavaScript project that imports VisualizationSurface, then verify the development console is clean with the supported dependency version and no longer reports the batchingForReactDom warning.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100