patternfly / patternfly/react-topology
topology - need guidance on responsive toolbars
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 21
- Forks
- 27
- PR merge metrics
- No merged PRs in 30d
Description
Topology's TopologyView.tsx creates a Toolbar component and simply provides props for the consumer to define the items to place in the toolbar (via the contextToolbar and the viewToolbar).
In consumers simple began packing ToolbarItems into these props, then they could end up with an unresponsive Toolbar, which would wrap weirdly.
More guidance should be provided for how to use the props in the TopologyView to create a responsive toolbar - especially with ToolbarToggleGroups and OverflowMenus.
Currently, Dev Sandbox has a topology toolbar which appears the following way on mobile views:
Additionally, I don't know if people are wanting to see a ToolbarFilter on their Topology toolbars, which would display applied filters as chips below the Toolbar controls. If so, guidance or even an update to the Topology view might be needed.
Jira Issue: PF-1996
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with packages/react-topology/src/components/TopologyView/TopologyView.tsx and inspect how contextToolbar and viewToolbar are exposed. Compare the documented usage with the Dev Sandbox mobile toolbar shown in the issue, including ToolbarToggleGroups and OverflowMenus. Done means providing clear responsive-toolbar guidance and resolving whether ToolbarFilter needs coverage.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- documentation, frontend
- Issue type
- Documentation
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100