patternfly / patternfly/react-topology

Update all demo code to import mobx functions from '@patternfly/react-topology'

Open
#308 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
21
Forks
27
PR merge metrics
No merged PRs in 30d

Description

Describe the enhancement or change
Projects should import mobx functions from '@patternfly/react-topology' because we allow for different versions using:

// Configure MobX to isolate state, this allows for applications to use different versions of MobX
configure({ isolateGlobalState: true });

If the project has a different version, it is likely that topology components will not update on changes appropriately.

All demo code should use the exported version from PF topology to provide good examples and follow this practice.


Jira Issue: PF-3488

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No specific files or tests are named. Search the demo code for imports of MobX functions, then inspect the package exports from @patternfly/react-topology. Done means all demo code imports those functions from the topology package and no direct MobX imports remain.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
developer-experience
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.