patternfly / patternfly/react-topology

Implement RTL support

Open
#116 4 comments 0 reactions 1 assignee View on GitHub

@jeff-phillips-18 is already working on this.

Since Jan 10, 2024.

Dominant language
TypeScript
Stars
21
Forks
27
PR merge metrics
No merged PRs in 30d

Description

Describe the problem
PatternFly now provides RTL language support, but topology has a few instances where it's causing problems. Node labels are one trouble spot.

How do you reproduce the problem?
Add dir="rtl" to the <body> tag to see it in RTL. Note that English text will still be readable left to right, but should be right aligned where it was previously left aligned, etc.

Screenshots

Any other information?
See the RTL handbook for help - in particular, the helper multiplier might be of use. https://www.patternfly.org/developer-resources/right-to-left-handbook#patternfly-rtl-helpers


Jira Issue: PF-2000

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.