Allow remember of the selected console

Open
#67 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
48/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
react, typescript
Domain
frontend

Research direction

Read the Accessconsole component and trace how its internal selected console type is changed through setType. Add the requested callback behavior so consumers can receive the selected type for persistence in localStorage. Done when the callback is invoked with the user-selected console type and existing console selection still works.

Written by the indexing model from the issue text.

Description

enhancement

In cockpit-machines we would like to remember the selected setting in the Accessconsole component, as this is internal state we would like to have a callback for setType which will be called with the then user selected console type.

That would allow us to retrieve the selected type state from outside the component and save it in localStorage in Cockpit-machines.

Jira Issue: PF-2015

Dominant language
TypeScript
Stars
5
Forks
16
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from patternfly/react-console

All issues in patternfly/react-console

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.