patternfly / patternfly/react-catalog-view
catalog-view-extension bug: links in CatalogTile do not work
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 3
- Forks
- 14
- PR merge metrics
- No merged PRs in 30d
Description
Due to the component preventing default from happening (unless href is set)
https://github.com/patternfly/patternfly-react/blob/5b472303da22cb9c67e9977b3933f6576c27ac01/packages/react-catalog-view-extension/src/components/CatalogTile/CatalogTile.tsx#L60
<CatalogTile description={
<div>
<a href="www.google.com">Does not work</a>
</div>
} />
Workaround is to also pass href="#" prop
Jira Issue: PF-2021
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in packages/react-catalog-view-extension/src/components/CatalogTile/CatalogTile.tsx at line 60, where the component prevents the default action. Reproduce the issue with a link inside the description without the href workaround. Done means links in CatalogTile descriptions work without requiring an href prop on CatalogTile.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100