patternfly / patternfly/react-catalog-view
Patternfly Catalog code is causing icon to be skewed
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 3
- Forks
- 14
- PR merge metrics
- No merged PRs in 30d
Description
Describe the issue. What is the expected and unexpected behavior?
This piece of CSS is causing this issue -> Catalog tile Icon is skewed (https://bugzilla.redhat.com/show_bug.cgi?id=2029977)
File: _catalog-tile.scss
.catalog-tile-pf-icon { //from
font-size: 40px;
height: 40px;
max-width: 60px;
min-width: 40px;
}
instead of
img is constrained on both width and height which should not happen
Please provide the steps to reproduce. Feel free to link CodeSandbox or another tool.
Is this a bug or enhancement? If this issue is a bug, is this issue blocking you or is there a work-around?
Bug. non blocking
What is your product and what release version are you targeting?
Openshift 4.10
Jira Issue: PF-2020
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting _catalog-tile.scss and the .catalog-tile-pf-icon rules described in the issue, then compare the constrained and expected catalog tile icons. Done means the icon is no longer constrained by both width and height and matches the expected proportions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- scss, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 38/100