patternfly / patternfly/patternfly
Bug - Avatar - visual regression bugs
Nobody has claimed this yet.
- Dominant language
- SCSS
- Stars
- 817
- Forks
- 116
- Avg merge
- 4d 11h
- Merged PRs (30d)
- 14
Description
- Looks like the a menu toggle with the div structure avatar doesn't truncate text like the avatar with the image. Can validate on an example like https://www.patternfly.org/components/compass/html-demos/multiple-sections/
-
Also the default avatar in our examples switched from an
imgto the div structure and we probably want to change that back to theimgstructure for now? WDYT @andrew-ronaldson should we update our use of the avatar in the masthead user menu to any of our new variants or just leave it using the existing grey avatar image for now? -
The avatars are bottom-aligned on full page examples - we should fix that so full page examples look better.
Jira Issue: PF-4318
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the Avatar examples and comparing the div and img structures against the linked multiple-sections demo. Check the full-page examples for bottom alignment. Done means long text truncates consistently, the intended default avatar structure is restored or confirmed, and avatars are visually aligned in full-page examples.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- html, scss
- Domain
- design, frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100