patternfly / patternfly/patternfly
Bug - Tabs - move "box" borders from link to list item, fix HC styles
Nobody has claimed this yet.
- Dominant language
- SCSS
- Stars
- 817
- Forks
- 116
- Avg merge
- 4d 11h
- Merged PRs (30d)
- 14
Description
Currently the "box" borders are on the tab link/button's ::before pseudo element, and those should be able to go to the parent list item instead.
Currently the high contrast border styles on the link/button are not using the correct tokens due to being directly on the link/button - if we freed up the ::before element, we could move the HC border styles to ::before and use the correct tokens.
Jira Issue: PF-2728
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the tab styles that place the box borders on the link or button's ::before pseudo-element, then inspect the parent list item and the high-contrast styles. Move the relevant border responsibilities to their intended elements and verify that the high-contrast styles use the correct tokens; confirm the tab appearance in high-contrast mode.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- scss
- Domain
- accessibility, frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 62/100