patternfly / patternfly/patternfly
Bug - Login - Spacing mismatched from HTML component
Nobody has claimed this yet.
- Dominant language
- SCSS
- Stars
- 817
- Forks
- 116
- Avg merge
- 4d 11h
- Merged PRs (30d)
- 14
Description
Describe the problem
The Login component in HTML side has spacing between the description and the username field. However the React side is missing that completely.
My hunch is that the spacing is to show invalid credentials as evident between the normal and invalid HTML demos.
How do you reproduce the problem?
See login component in HTML vs React to notice the padding issue.
Expected behavior
Be it HTML or React side, this difference brings uncertainty.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the HTML and React login-page demos linked in the issue, focusing on the spacing between the description and username field. Trace the relevant Login component styles and determine whether the difference is intentional for invalid credentials; done means the two demos have consistent, documented spacing or an agreed exception.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, scss
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100