Carryover `line-height`s are affected element alignment

Open

#6,876 opened on Jul 11, 2024 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Stale

Dominant language: SCSS
Stars: 817
Forks: 116
Avg merge: 4d 11h
Merged PRs (30d): 14

Description

TLDR

There are several line-height: 1; definitions in our codebase, and after updating to flex/inline-flex grid/inline-grid line-height: 1; affects element positioning.

After a quick search, here are several instances that should be reviewed:

Contributor guide

Open the contributing guide

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Research direction

Start with the listed SCSS files and review each line-height: 1; definition in the context of its flex, inline-flex, grid, or inline-grid layout. Compare the affected component alignment before and after the update. Done means every listed instance has been reviewed and the unintended positioning effects are resolved.

Written by the indexing model from the issue text.

Assessment

Tech stack: scss
Domain: design, frontend, web-dev
Issue type: Bug
Difficulty: 4/5
Estimated time: 3-5 days
Activity status: Stale
Clarity: Mostly clear
Newbie friendliness: 35/100