patternfly / patternfly/patternfly

Refactor dual list selector to use tree view component

Open
#5,746 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Pinned
Dominant language
SCSS
Stars
817
Forks
116
Avg merge
4d 11h
Merged PRs (30d)
14

Description

The end goal would be to update the dual list tree view to use the tree view component. AFAIK the reason dual list did not use the tree view component initially was due to the differences in visual presentation (and number of overrides that would be needed in the dual list selector to account for the differences) and that using a component in another component (outside of a simple drop-in use case) can tie the styling of the nested component to its markup. A good example of that is including .pf-c-title.pf-m-xl for the title in a component, and design wants to change the font-size of that title. Since the font-size is tied to the markup (class="pf-m-xl"), react can make the update to change the title class, but non-react users now require action to get the update and their titles will be inconsistent until they do, which can possibly be a breaking change.

For now, I think this issue should be as spike, and we

  • Identify the differences between tree view and the dual list selector's tree view
  • Create an issue in the design repo and collaborate with the goal of normalizing those differences so we can use the tree view as-is in the dual list selector without any overrides.
    • Since using it as-is probably isn't likely, try and identify any variations/overrides needed to support being able to drop the tree view component into the dual list selector without setting us up for breaking changes.

related design issue https://github.com/patternfly/patternfly-design/issues/1274

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the dual list selector and tree view documentation linked in the issue, then review the related PatternFly design issue 1274. Document their visual and markup differences, create or update the design-repo issue, and identify the variations or overrides needed to use tree view without breaking changes.

Written by the indexing model from the issue text.

Assessment

Tech stack
html, scss
Domain
design, frontend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.