patternfly / patternfly/patternfly
[Flex] - [gap based spacer on the flex layout should be the default]
Nobody has claimed this yet.
- Dominant language
- SCSS
- Stars
- 817
- Forks
- 116
- Avg merge
- 4d 11h
- Merged PRs (30d)
- 14
Description
Please don't introduce one more option for the users to change flex's behavior.
The internals of how spacing is implemented is totally not interesting for the consumers, it's a Patternfly implementation detail. Using flex gap is an enhancement over the old margin based implementation (see RTL) and should be pushed/forced as change and not let in the consumers preference .
I do not understand/support the idea of making it a opt-in as this approach with opt ins just pollutes the codebase of the consumers.
So I encourage you to drop the old margin based solution and adopt as default the gap based.
After all v5 is a breaking release and it should be accomodating such breaking changes which will improve the underlying products. Otherwise, I doubt that anyone would care to switch to adding these new modifer opt-in classes for gap spacing, thus getting stuck with the v4 suboptimal implentation.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue points to the Flex spacing implementation in PatternFly's core HTML/CSS/SCSS code, contrasting the existing margin-based behavior with flex gap and RTL handling. Start by locating that implementation and any opt-in modifier classes; done means gap spacing is the default and the old margin-based option is no longer required, with RTL behavior preserved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- css, scss
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100