patternfly / patternfly/patternfly

Update button component examples to be more clear

Open
#3,946 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Pinned
Dominant language
SCSS
Stars
817
Forks
116
Avg merge
4d 11h
Merged PRs (30d)
14

Description

From https://github.com/patternfly/patternfly/pull/3932#pullrequestreview-618954408

One thing I might consider is that with increasing number of variations, we might separate them by example. There are enough variants at this point, I get a little lost looking at all the buttons in the same space without labels to distinguish between them.

cc @mceledonia @mcarrano wdyt?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the button component examples and the referenced discussion in pull request #3932. Separate the variants into clearly labeled examples as suggested, then verify that each button variation remains represented and understandable.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, html, scss
Domain
documentation
Issue type
Documentation
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.