patternfly / patternfly/patternfly-react
cleanup - DataListAction - id, aria-label and aria-labelledby are not currently in use but are required
Open
Nobody has claimed this yet.
Breaking change :boom:
PF Team
Pinned
- Dominant language
- TypeScript
- Stars
- 862
- Forks
- 392
- Avg merge
- 4d 8h
- Merged PRs (30d)
- 9
Description
id can probably remain (and if so should be made non-required) but aria-label and aria-labelledby should be removed because they don't usually exist on a div without a role. These props were a holdover from when we were using a Button internally opposed to children.
Jira Issue: PF-107
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the DataListAction component and inspect its prop definitions and usages. Confirm whether id is still needed and can be optional, then remove the unused aria-label and aria-labelledby props. Done means the public props and related references consistently reflect the component's current children-based implementation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- accessibility, frontend
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100