patternfly / patternfly/patternfly-react
Bug - ClipboardCopy - ClipboardCopyToggle has a div within a button
Open
Nobody has claimed this yet.
Breaking change :boom:
PF Team
Waiting for core
- Dominant language
- TypeScript
- Stars
- 862
- Forks
- 392
- Avg merge
- 4d 8h
- Merged PRs (30d)
- 9
Description
Followup to https://github.com/patternfly/patternfly/issues/6019
Describe the problem
ClipboardCopy's expansion toggle currently has a div within a button, which is invalid markup.
Expected behavior
The pf-v5-c-clipboard-copy__toggle-icon element should be a span rather than a div.
Jira Issue: PF-111
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the ClipboardCopyToggle component and locate the pf-v5-c-clipboard-copy__toggle-icon element. Confirm the toggle's rendered markup, change that element to a span, and verify that the expansion toggle no longer contains a div within its button.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 58/100