patternfly / patternfly/patternfly-react
Popper - possibly add as a dependency
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 862
- Forks
- 392
- Avg merge
- 4d 8h
- Merged PRs (30d)
- 9
Description
Is this a new component or an extension of an existing one?
Popper
Describe the feature
A README in our helpers/Popper/thirdparty directory mentions:
- Delete the thirdparty folder and add them as dependencies to the package.json:
"react-popper": "2.2.3"
"@popperjs/core": "2.4.2"
Most likely not as part of this breaking change, but is this something we'd want to look into for a future major release? An alternative would be https://github.com/patternfly/patternfly-react/issues/9089 which would involve just updating our thirdparty code (possibly).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the README in helpers/Popper/thirdparty and the package.json references to react-popper and @popperjs/core. Compare this dependency approach with the alternative described in patternfly-react issue 9089, then clarify which future-release direction is desired and what replacing the third-party folder would include.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100