patternfly / patternfly/patternfly-react
Tooltip- rename trigger prop
Open
Nobody has claimed this yet.
Breaking change :boom:
PF Team
- Dominant language
- TypeScript
- Stars
- 862
- Forks
- 392
- Avg merge
- 4d 8h
- Merged PRs (30d)
- 9
Description
Currently the trigger prop is very similar to Popper's trigger prop, can it's purpose can be confused with triggerRef that will exist for Popper. Since it's an action trigger for the tooltip, maybe it can be renamed to triggerEvent instead.
Jira Issue: PF-139
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Tooltip component's trigger prop and searching the repository for its usages, including tests and documentation. Rename the action prop consistently to triggerEvent, updating all references so the Tooltip API and its tests use the new name.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100