patternfly / patternfly/patternfly-react

Drilldown class updates to match core

Open
#8,418 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Breaking change :boom: PF Team Waiting for core
Dominant language
TypeScript
Stars
862
Forks
392
Avg merge
4d 8h
Merged PRs (30d)
9

Description

placeholder for https://github.com/patternfly/patternfly/issues/5274

It would probably be useful to introduce classes on the drilldown menu that give us finer control over targeting/styling elements based on their state as the menu is modified.

This comment provides an example of the intended update.

https://github.com/patternfly/patternfly/pull/5271#issue-1471825828

cc @thatblindgeye


Jira Issue: PF-154

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked core issue 5274 and the example in pull request 5271, then locate the drilldown menu implementation in patternfly-react. Compare the React component's state-related classes with the intended core update; done means the drilldown exposes matching classes for the relevant menu states.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.