patternfly / patternfly/patternfly-react
Calendar month - updates from padding change
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 862
- Forks
- 392
- Avg merge
- 4d 8h
- Merged PRs (30d)
- 9
Description
Placeholder for https://github.com/patternfly/patternfly/issues/5272
We're removing the calendar month component's built-in padding. This will most likely involve updating any place the calendar month is used to make sure the thing the calendar month is in provides padding for the calendar. eg, remove hasNoPadding from the datepicker popover.
Jira Issue: PF-155
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the DatePicker component in packages/react-core/src/components/DatePicker/DatePicker.tsx around line 244, then identify other places where the calendar month is used. Check the related PatternFly issue for the intended padding change. Done means the calendar month no longer provides built-in padding and its containing components provide the required padding instead.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100