patternfly / patternfly/patternfly-react
Bug - NumberInput: values/validation status not announced to assistive tech on update
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 862
- Forks
- 392
- Avg merge
- 4d 8h
- Merged PRs (30d)
- 9
Description
Describe the problem
Followup to #7806. Relevant comment chains: https://github.com/patternfly/patternfly-react/pull/7806#pullrequestreview-1077847330, https://github.com/patternfly/patternfly-react/pull/7806#pullrequestreview-1077854208, and https://github.com/patternfly/patternfly-react/pull/7806#issuecomment-1220611457
How do you reproduce the problem?
-
Go to Number input
-
Turn on VoiceOver or another screen reader
-
Use keyboard to update the input (either via the +/- buttons or within the input itself)
-
Notice the value does not get announced
- In Chromium browsers, updating via buttons or via the input itself does not trigger an announcement. In Firefox and Safari, updating via the input announces the new value but updating via the buttons does not.
Expected behavior
The new value of the input and/or the validation status is announced to assistive tech
Is this issue blocking you?
N/A
Screenshots
N/A
What is your environment?
N/A
What is your product and what release date are you targeting?
N/A
Any other information?
N/A
Jira Issue: PF-174
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Number input component at https://www.patternfly.org/v4/components/number-input and review the linked discussion in PR #7806 and its comments. Reproduce updates with VoiceOver or another screen reader in Chromium, Firefox, and Safari, then verify that value and/or validation changes are announced for both button and direct-input updates.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- accessibility, frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100