patternfly / patternfly/patternfly-react
Bug - [LoginForm] - `autoComplete` is not exposed and cannot be defined in the LoginForm.
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 862
- Forks
- 392
- Avg merge
- 4d 8h
- Merged PRs (30d)
- 9
Description
Describe the problem
Unable to define autoComplete on the LoginForm, as this value isn't exposed.
How do you reproduce the problem?
Examine the LoginForm source and confirm
Expected behavior
LoginForm should expose autoComplete (or inputProps) on its name and password TextInput. This would allow values such as autocomplete="current-password" or autocomplete="new-password" to be provided.
Is this issue blocking you?
No.
Screenshots
N/A
What is your environment?
N/A
What is your product and what release date are you targeting?
Any other information?
Jira Issue: PF-4510
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by examining the LoginForm source and the name and password TextInput usage. Expose autoComplete or inputProps for those inputs, then verify that callers can provide values such as current-password and new-password.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- authentication, frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100