patternfly / patternfly/patternfly-react
Bug - [MenuToggle] - [No way to show a tooltip with a disabled MenuToggle]
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 862
- Forks
- 392
- Avg merge
- 4d 8h
- Merged PRs (30d)
- 9
Description
Describe the problem
Following the aria disabled button with tooltip example, I want to apply the same to the MenuToggle but it has no isAriaDisabled or support to show a tooltip when the MenuToggle is disabled
How do you reproduce the problem?
import { MenuToggle, Tooltip } from '@patternfly/react-core';
export const MenuToggleDisabled: React.FunctionComponent = () => <Tooltip content="spooky"><MenuToggle isDisabled>Disabled</MenuToggle></Tooltip>;
Expected behavior
isAriaDisabled is supported and showing a tooltip works.
Is this issue blocking you?
No, for now we just show a disabled DropdownItem when no menu items are available.
Screenshots
If applicable, add screenshots to help explain the issue.
What is your environment?
- OS: [e.g. iOS]
- Browser [e.g. chrome, safari]
- Version [e.g. 22]
What is your product and what release date are you targeting?
Cockpit.
Any other information?
None.
Jira Issue: PF-4329
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the MenuToggle component and compare its disabled behavior with the ARIA-disabled button example linked in the issue. Verify the Tooltip-wrapped MenuToggle reproduction, then add support for isAriaDisabled and tests showing that a disabled MenuToggle can display its tooltip.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- accessibility, frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100